s0me1newithhand7s/system-manager
1
1
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use TODO everywhere.

Browse source
This commit is contained in:
r-vdp 2023-03-22 23:16:25 +01:00
parent e60fa080b4
commit 47f32ccea7
No known key found for this signature in database
3 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/activate/services.rs
View file

@ -227,7 +227,7 @@ fn restore_ephemeral_system_dir() -> Result<()> {
Ok(()) Ok(())
} }
// FIXME: we should probably lock this file to avoid concurrent writes // TODO: we should probably lock this file to avoid concurrent writes
fn serialise_saved_services(services: &Services) -> Result<()> { fn serialise_saved_services(services: &Services) -> Result<()> {
let state_file = Path::new(SYSTEM_MANAGER_STATE_DIR).join(SERVICES_STATE_FILE_NAME); let state_file = Path::new(SYSTEM_MANAGER_STATE_DIR).join(SERVICES_STATE_FILE_NAME);
DirBuilder::new() DirBuilder::new()

2
src/lib.rs
View file

@ -25,7 +25,7 @@ pub struct StorePath {
impl From<String> for StorePath { impl From<String> for StorePath {
fn from(path: String) -> Self { fn from(path: String) -> Self {
// FIXME: handle this better // TODO: handle this better
if !path.starts_with("/nix/store/") { if !path.starts_with("/nix/store/") {
panic!("Error constructing store path, not in store: {path}"); panic!("Error constructing store path, not in store: {path}");
} }

5
src/main.rs
View file

@ -75,7 +75,7 @@ enum Action {
} }
fn main() -> ExitCode { fn main() -> ExitCode {
// FIXME: set default level to info // TODO: set default level to info
env_logger::Builder::from_env(env_logger::Env::default().default_filter_or("debug")).init(); env_logger::Builder::from_env(env_logger::Env::default().default_filter_or("debug")).init();
handle_toplevel_error(go(Args::parse())) handle_toplevel_error(go(Args::parse()))
} }
@ -92,7 +92,6 @@ fn go(args: Args) -> Result<()> {
store_path, store_path,
activation_args: ActivationArgs { ephemeral }, activation_args: ActivationArgs { ephemeral },
} => { } => {
// FIXME handle target_host
copy_closure(&store_path, &target_host)?; copy_closure(&store_path, &target_host)?;
activate(&store_path, ephemeral, &target_host, use_remote_sudo) activate(&store_path, ephemeral, &target_host, use_remote_sudo)
} }
@ -101,7 +100,7 @@ fn go(args: Args) -> Result<()> {
} => build(&flake_uri, &target_host), } => build(&flake_uri, &target_host),
Action::Deactivate => { Action::Deactivate => {
check_root()?; check_root()?;
// FIXME handle target_host // TODO handle target_host
deactivate() deactivate()
} }
Action::Generate { generate_args } => { Action::Generate { generate_args } => {